Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added E2E tests for externalAppCardActionsForCEA APIs #2530

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added E2E tests for externalAppCardActionsForCEA APIs #2530

wants to merge 5 commits into from
+44 −14

Conversation

MengyiGong
Copy link
Contributor

@MengyiGong MengyiGong commented Sep 26, 2024 •
edited
Loading

For more information about how to contribute to this repo, visit this page.

Main changes in the PR:

  1. Added E2E test for externalAppCardActionsForCEA APIs.
  2. Fixed the format issue

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

End-to-end tests added:

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

@MengyiGong MengyiGong force-pushed the maggieg/add_externalAppCardActionForCEA_e2e branch 2 times, most recently from 5367ce4 to 58b023d Compare September 27, 2024 03:38
@MengyiGong MengyiGong force-pushed the maggieg/add_externalAppCardActionForCEA_e2e branch from 58b023d to db57863 Compare September 27, 2024 03:52
@MengyiGong MengyiGong marked this pull request as ready for review September 27, 2024 04:57
@MengyiGong MengyiGong requested a review from a team as a code owner September 27, 2024 04:57
@MengyiGong MengyiGong force-pushed the maggieg/add_externalAppCardActionForCEA_e2e branch from db57863 to f190983 Compare September 27, 2024 05:11
TrevorJoelHarris
TrevorJoelHarris requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@TrevorJoelHarris TrevorJoelHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small changes

@MengyiGong
Copy link
Contributor Author

Thank you @TrevorJoelHarris ! All addressed.

AE-MS
AE-MS approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorJoelHarris TrevorJoelHarris TrevorJoelHarris requested changes

@AE-MS AE-MS AE-MS approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MengyiGong @TrevorJoelHarris @AE-MS